Skip to content

Hard-code /opt/photonvision/image-metadata.json, assert in smoketests - #2585

Merged
mcm001 merged 5 commits into
PhotonVision:mainfrom
mcm001:check-smoketest
Aug 15, 2026
Merged

Hard-code /opt/photonvision/image-metadata.json, assert in smoketests#2585
mcm001 merged 5 commits into
PhotonVision:mainfrom
mcm001:check-smoketest

Conversation

@mcm001

@mcm001 mcm001 commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

Description

What changed?

  • Hard-code /opt/photonvision/image-metadata.json as the location of the metadata file
  • Assert we can parse this file in all image smoketests

Why?

image

Our current build pipelines are failing to locate this file, but nobody's making sure that it exists. We should be more defensive -- right now this file does very little but help us debug, but in the future, we might need this to drive additional vendor configuration.

Testing

CI will fail if this doesn't work :)


AI Disclosure

  • This PR was authored entirely by me
  • This PR includes AI-generated code (e.g., from GitHub Copilot, ChatGPT)
    • Copilot wrote my greps

Merge Checklist

Additional Checks (if applicable)

  • User-facing changes? User documentation is updated
  • Breaking changes? Migration guide is included in description and migrations are marked with // MIGRATION: <dataYear> where <dataYear> is the last season the pre-migration data was used in
  • Bug fix? Regression test is added
  • New dependency? License compatibility is verified and steps have been taken to follow it
  • Serde changes? All messages are regenerated with no unexpected hash changes
  • Configuration changes? Changes are backwards compatible with previous season's last release
  • Pipeline/data exchange changes? Frontend types are updated in ./photon-client/src/types

@mcm001
mcm001 requested a review from a team as a code owner August 9, 2026 23:40
@github-actions github-actions Bot added the backend Things relating to photon-core and photon-server label Aug 9, 2026
Comment thread .github/workflows/build.yml Outdated
crschardt
crschardt previously approved these changes Aug 13, 2026

@crschardt crschardt left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion, everything else looks fine.

Co-authored-by: Craig Schardt <crschardt@fastem.com>
@mcm001
mcm001 merged commit 5c7969e into PhotonVision:main Aug 15, 2026
87 of 88 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend Things relating to photon-core and photon-server

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants